Wrong annotation prefix for LB/ingress hostname
vbehar opened this issue · comments
Environment:
- Kubernetes distribution (e.g. AKS, ACS Engine, GKE, EKS, etc.):
- Kubernetes version (use
kubectl version
): - Osiris version (specify by SHA or semver): 0.0.1-2018.12.17.14.39.01-f3f1817
- Install method (specify exact
helm install
command used):
What happened?
- tried the basic example from the README, didn't work (got a 404) because "request_handling.go:25] No deployment found for host xxx.yyy"
- tried using the
osiris.deislabs.io/loadBalancerHostname
found in the hello-osiris example, and then theosiris.deislabs.io/ingressHostname
, but it didn't worked
What you expected to happen?
- making a request would scale up the deployment, and I would get a 200 response
How to reproduce it (as minimally and precisely as possible):
Anything else that we need to know?
- I made it work by looking at the code, and found that the annotation prefix should be
osiris.io
- see https://github.com/deislabs/osiris/blob/master/pkg/deployments/activator/index.go