deislabs / containerd-wasm-shims

containerd shims for running WebAssembly workloads in Kubernetes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

add --version flag to the CLI args

devigned opened this issue · comments

It would be nice to have a --version arg for the shims to be able to determine the build version information. Currently, there is no way to easily determine the version of the shim bin.

Can you elaborate more on where the --version argument is passed to?

This is the current behaviour:
image

Do you envision instead of the above, it will prints out the version info?

Yes. It doesn't need to be --version, but in some way to be able to determine what version is running. In cases where we need to debug an issue, it would be super helpful for someone to easily determine the version / build of a shim on their system and then open an issue with that info.

I think containerd-shim is probably a better place to add the version flag. Here is an issue I created containerd/rust-extensions#120

We should follow what's done in containerd/rust-extensions#167 to bring the version flag to all the shims.

Close by #145