Remove unecessary type assertions
krancour opened this issue · comments
Kent Rancourt commented
Example: https://github.com/deis/logger/blob/master/syslogish/server.go#L129
These aren't needed. They probably were needed at a moment in time and then weren't as the code evolved. They can go.
Aaron Schlesinger commented
Most type assertions will be removed when @jchauncey finishes changing architecture according to #84. His working branch is at https://github.com/jchauncey/logger/tree/use-nsq
Joshua Anderson commented
nsq work has now been merged. @jchauncey is this still an issue?
Kent Rancourt commented
The refactor eliminated the code in question.