Upgrade mcrypt_create_iv to support PHP 7.2 (and add travis-ci tests for new PHP versions)

Question

Upgrade mcrypt_create_iv to support PHP 7.2 (and add travis-ci tests for new PHP versions)

defuse opened this issue 7 years ago · comments

Taylor Hornby commented 7 years ago

This is urgent, since some users are wanting to upgrade to 7.2.

Taylor Hornby · Answer 1 · Thu Jan 25 2018 05:25:29 GMT+0800 (China Standard Time)

Actually this has already been done!

Luckydonald · Answer 2 · Fri Apr 17 2020 19:36:42 GMT+0800 (China Standard Time)

I was looking at this as my IDE highlighted that mcrypt_create_iv function as depricated.
Maybe a comment above those functions along the lines of // PHP 7.2+ and // Fallback for PHP < 7.2 could be added for immediate clarity?