Update path to istanbul assets

Question

Update path to istanbul assets

kof opened this issue 9 years ago · comments

Oleg Isonen commented 9 years ago

Files like this one are moved in instanbul to assets dir.

zuul/node_modules/istanbul-middleware/node_modules/istanbul/lib/vendor/prettify.css

Vincent Voyer commented 9 years ago

Allright

Roman Shtylman · Answer 1 · Mon Oct 26 2015 08:58:21 GMT+0800 (China Standard Time)

@vvo ping, something from a recent update?

Vincent Voyer · Answer 2 · Tue Oct 27 2015 06:02:38 GMT+0800 (China Standard Time)

@lpinca any hints? You did an istanbul related PR.

Vincent Voyer · Answer 3 · Tue Oct 27 2015 06:03:02 GMT+0800 (China Standard Time)

Also @kof I am not sure to understand what you are asking for, can you be more specific on what's wrong?

Oleg Isonen · Answer 4 · Tue Oct 27 2015 06:05:44 GMT+0800 (China Standard Time)

just install the latest version, remove node_modules and you will get it when you run some tests locally, it will try to load some files from a non-existing location.

Vincent Voyer · Answer 5 · Tue Oct 27 2015 06:19:46 GMT+0800 (China Standard Time)

I still don't get how to fix this eheh. What to fix

Luigi Pinca · Answer 6 · Tue Oct 27 2015 15:01:33 GMT+0800 (China Standard Time)

I can reproduce this and yes it is caused by the istanbul-middleware update (my pr).
If you pin down istanbul to version 0.2.x in instabul-middleware, it works. A newer istanbul generates this issue.

I will try to investigate as soon as I find some time.

To repoduce the issue:

Install latest zuul
Run zuul --local 8080 -- test.js
Open the url shown by zuul in a browser

Roman Shtylman · Answer 7 · Tue Oct 27 2015 15:27:11 GMT+0800 (China Standard Time)

@vvo lets revert the update since it seems to break for users and needs more testing

Vincent Voyer · Answer 8 · Tue Oct 27 2015 16:29:56 GMT+0800 (China Standard Time)

Ok published 3.7.2 with reverted istanbul-middleware, @lpinca would be good to get your insights when you have time :D

Luigi Pinca · Answer 9 · Tue Oct 27 2015 16:30:58 GMT+0800 (China Standard Time)

@vvo sure, I will take a look, I just have to find a little time 😄

Luigi Pinca · Answer 10 · Tue Oct 27 2015 22:39:47 GMT+0800 (China Standard Time)

gotwarlost/istanbul#467
gotwarlost/istanbul-middleware#26

istanbul-middleware@0.2.1 is broken, we have to wait for the next version.

Vincent Voyer · Answer 11 · Wed Oct 28 2015 05:56:11 GMT+0800 (China Standard Time)

Nice, open a new PR when ready then :)