defunctzombie / npm-css

Require css from npm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

why do you use cssp? why not rework?

jonathanong opened this issue · comments

it's all in russian. i don't know what's going on.

I think this was before rework existed? Or maybe before I knew about
rework. Happy to change it if it functions the same!
On Dec 16, 2013 4:02 AM, "Jonathan Ong" notifications@github.com wrote:

it's all in russian. i don't know what's going on.


Reply to this email directly or view it on GitHubhttps://github.com//issues/10
.

I also found this: https://github.com/conradz/rework-npm

The main difference is that npm-css auto-prefixes based on module to avoid leaking, but maybe that is too opinionated.

@jonathanong cssp is used because i couldnt find any decent CSS parsers and substack has used cssp in the past. If its good enough for substack, its good enough for me.

Also most CSS parsers DO NOT PARSE COMMENTS. cssp does.

Last time I checked rework does not parse comments.

A previous version of npm-css used // @require 'foo'

Yeah it parses comments. It doesn't keep formatting exact though.

We don't need comment parsing anymore, but we do need the preserve the auto-prefix feature. Maybe I will just make a rework module that uses rework-npm and then does the prefixing as an option :/

We can probably use this module: https://github.com/conradz/rework-npm