defunctzombie / ansible-coreos-bootstrap

[NOT MAINTAINED] bootstrap a coreos machine for control via ansible

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

General design is not very "ansible like"

tobilarscheid opened this issue · comments

Hi everyone,

I feel like the general design of the role is not following the normal "ansible way" if there is something like this. What do I mean by this? Checking if something is installed by running into an error is uncommon. Normally in ansible you just specify the desired state and ansible checks if any changes have to be run. Using the standard ansible plugins instead of shell plugins is also recommended wherever possible. I don't how big of a rewrite this would mean for this extension (did not yet look at the code), just wanted to bring up this issue and start a discussion.

Regards,

Tobi

Using the standard ansible plugins instead of shell plugins is also recommended wherever possible

Ansible requires python on the target host to be able to use modules. In this case python is not installed, there is no other choices than to use raw.

Checking if something is installed by running into an error

ItIt a quite common pattern. When you have multiple steps to generate an artifact, you first check if the artifact is present.