Columns and DataType Not Explicitly Set on line 65 of test_train.py

[CodeSmileBot]

Hello!

I found an AI-Specific Code smell in your project.
The smell is called: Columns and DataType Not Explicitly Set

You can find more information about it in this paper: https://dl.acm.org/doi/abs/10.1145/3522664.3528620.

According to the paper, the smell is described as follows:

Problem	If the columns are not selected explicitly, it is not easy for developers to know what to expect in the downstream data schema. If the datatype is not set explicitly, it may silently continue the next step even though the input is unexpected, which may cause errors later. The same applies to other data importing scenarios.
Solution	It is recommended to set the columns and DataType explicitly in data processing.
Impact	Readability

Example:

### Pandas Column Selection
import pandas as pd
df = pd.read_csv('data.csv')
+ df = df[['col1', 'col2', 'col3']]

### Pandas Set DataType
import pandas as pd
- df = pd.read_csv('data.csv')
+ df = pd.read_csv('data.csv', dtype={'col1': 'str', 'col2': 'int', 'col3': 'float'})

You can find the code related to this smell in this link:

spleeter/tests/test_train.py

Lines 55 to 75 in 19b523f

     fs=44100, 
     duration=6, 
 ): 
     """ 
     generates a fake training dataset in path: 
     - generates audio files 
     - generates a csv file describing the dataset 
     """ 
     aa = AudioAdapter.default() 
     rng = np.random.RandomState(seed=0) 
     dataset_df = pd.DataFrame( 
         columns=["mix_path"] 
         + [f"{instr}_path" for instr in instrument_list] 
         + ["duration"] 
     ) 
     for song in range(n_songs): 
         song_path = join(path, "train", f"song{song}") 
         makedirs(song_path, exist_ok=True) 
         dataset_df.loc[song, "duration"] = duration 
         for instr in instrument_list + ["mix"]: 
             filename = join(song_path, f"{instr}.wav") 

.

I also found instances of this smell in other files, such as:

File: https://github.com/deezer/spleeter/blob/master/spleeter/__main__.py#L178-L188 Line: 183
File: https://github.com/deezer/spleeter/blob/master/spleeter/utils/tensor.py#L149-L159 Line: 154
.

I hope this information is helpful!