Potential Issue in CI Workflow Affecting Code Coverage Accuracy

[Yunbo Lyu]

Hello,

I'm working on collecting code coverage for this excellent project and have encountered a potential issue with the CI workflow. Specifically, five jobs in GitHub Actions [conda(ubuntu-latest, nvidia); conda(ubuntu-latest, rocm); conda(macos-latest, nvidia); conda(windows-latest, nvidia); conda(windows-latest, directml)] do not execute simple and end-to-end tests. One job in GitHub Actions [conda(macos-latest, cpu)] does not execute end-to-end tests. This happened in your recent GHA.
This seems to omit coverage for GPU-related or other code in /lib.

I've proposed a change in this commit: GitHub Commit - d3da0fb and generated a corresponding code coverage report here: Code Coverage Report.

Could you please review this potential issue and confirm the change accurately reflects your repository's code coverage?

Thank you for your exceptional work on this project, and I apologize for any inconvenience my inquiries may cause.

Best,
Yunbo

[torzdf]

The jobs are explicitly excluded as per the notes in https://github.com/deepfakes/faceswap/blob/master/.github/workflows/pytest.yml

# These backends will fail as GPU drivers not available
if: matrix.backend != 'rocm' && matrix.backend != 'nvidia' && matrix.backend != 'directml'
run: |
  FACESWAP_BACKEND="${{ matrix.backend }}" py.test -v tests/;
- name: End to End Tests
# These backends will fail as GPU drivers not available
# macOS fails on first extract test with 'died with <Signals.SIGSEGV: 11>'
if: matrix.backend != 'rocm' && matrix.backend != 'nvidia' && matrix.backend != 'directml' && matrix.os != 'macos-latest'        

If you are serious about improving the coverage of tests within the faceswap process, rather than just looking to shill another project, then we would very much welcome PRs that introduce more unit-tests, or look to resolve the above noted issues.

Please open a new issue/PR if you wish to contribute. This issue is closed as the problem disclosed is already known and documented.