EntmaxBisect forward requires unused argument

Question

EntmaxBisect forward requires unused argument

bpopeters opened this issue 5 years ago · comments

The forward method EntmaxBisect takes a required alpha argument. However, what is actually passed passed to the entmax_bisect function is self.alpha.

Vlad Niculae · Answer 1 · Wed Oct 30 2019 22:26:53 GMT+0800 (China Standard Time)

Good catch. That argument from the forward method should be removed, IMO.

Charles Dorner · Answer 2 · Mon Dec 07 2020 14:31:15 GMT+0800 (China Standard Time)

This is fixed in code but not in the default package when installed. I think it would be worth a 1.0.1 release.

Edit: For clarity, if you install the current package and try to use EntmaxBisect class, it fails when forward is called. The existing code change fixes that. A 1.0.1 release would ensure the default package contains this fix.