Support croppie 2.6.1

Question

Support croppie 2.6.1

gigadie opened this issue 6 years ago · comments

Hi,

I tried to see if using croppie 2.6.1 would fail, and it does. It would be cool if we could have support of the latest version of croppie in this fantastic component.

Thanks

Dan Jordan · Answer 1 · Tue Feb 27 2018 01:59:33 GMT+0800 (China Standard Time)

Thanks for submitting an issue,what's the problem you get with 2.6.1? Could it be related to this Foliotek/Croppie#470

Diego F · Answer 2 · Mon Mar 26 2018 23:32:29 GMT+0800 (China Standard Time)

Hi,

Exactly, the problem is that.

Jaye · Answer 3 · Tue Mar 27 2018 18:39:30 GMT+0800 (China Standard Time)

Tried to get it working before my vacation 3 or 4 weeks ago and provide a PR for this, but no luck. So atm best way is to lock croppie version in packages.json to 2.5.1 and wait for Foliotek/Croppie#470.

Dan Jordan · Answer 4 · Fri Apr 13 2018 20:50:22 GMT+0800 (China Standard Time)

v1.0.0 supports 2.6 and above but unfortunately ONLY 2.6 and above. Considering what the fix was I'd also expect it to break again when they undo the change in the issue above

Jaye · Answer 5 · Fri Apr 13 2018 23:09:07 GMT+0800 (China Standard Time)

Nice work @deej81 👍

If somebody is running into problems like:
ERROR in node_modules/ngx-croppie/src/app/modules/ngx-croppie/ngx-croppie.component.d.ts(1,23): error TS2688: Cannot find type definition file for 'croppie'.

make sure croppie typings are installed:
npm i @types/croppie --save-dev

Dan Jordan · Answer 6 · Sun Apr 15 2018 16:33:30 GMT+0800 (China Standard Time)

Thanks @dklmuc I ran into that with the example and forgot to mention it. Going to close this issue now although I think the fix from the croppie team will come this week and break this again.