Brown should be renamed Yellow
mattmc3 opened this issue · comments
I think the standard terminal color names are "black red green yellow blue magenta cyan white". This plugin uses the word "brown" for "yellow". Of course, you can set your actual colors to anything and make yellow look brown if you want in your terminal. But, for the purpose of this plugin and naming the color palate, it seems like renaming brown to yellow would make more sense to people who are modifying their lscolors. Would you be open to a PR that makes this change? Any concerns about it breaking for current users?
I suppose it's also worth mentioning that this project uses "grey" instead of "white" as well, and that is somewhat unconventional as well. Projects like Zsh alias "grey" to "black", not "white": https://github.com/zsh-users/zsh/blob/master/Functions/Misc/colors