deathbeds / jupyterlab-starters

Starter notebooks and directories in JupyterLab

Home Page:https://jupyterstarters.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Schema level title and description twice on the generated starter form

datakurre opened this issue · comments

When, e.g. on jupyterlab-starters binder, I update "Multi-Stage Starter Notebook"'s schema to include title and description:

    "schema": {
     "title": "Schema title",
     "description": "Schema description",
     "properties": {
      "name": {
       "description": "What is your name?",
       "title": "Name",
       "type": "string"
      }
     },

The form opened from the launcher will show title and description twice:

Schema title

Schema description

Schema title

Schema description

Name*

What is your name?

    is a required property

Also the layout is pretty tight:

jupyterlab-starters

for

    "schema": {                                                                         
     "title": "# Welcome to Robot Framework on Jupyter",                                
     "description": "Please, click **START** to launch the tutorial.",                  
     "properties": {},                                                                  
     "required": []                                                                     
    },  

Ah. The formatting issue aside, it appears that adding type clears up the duplicate title and description:

    "schema": {
     "type": "object",  # <--- this right here
     "title": "# Welcome to Robot Framework on Jupyter",                                
     "description": "Please, click **START** to launch the tutorial.",                  
     "properties": {},                                                                  
     "required": []                                                                     
    },  

Could actually demand that the root-level schema be an object...

@bollwyvl Thanks. Can confirm the fix. I close this and open another issue about the styling.