deanmcpherson / react-native-sortable-listview

Drag drop capable wrapper of ListView for React Native

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't apply shadow styling to SortRow on iOS

jd20 opened this issue · comments

Attempting to apply a shadow to the active row using sortRowStyle prop doesn't seem possible. The shadow simply doesn't appear. If I remove the overflow: 'hidden' from SortRow's base style, the shadow does appear, so I suspect this is an iOS/RN issue (seems described here: facebook/react-native#449).

Any particular reason for the overflow: hidden? Would it be better to leave it off the base style, and let the end user pass it via sortRowStyle if needed? I can submit a PR if you'd like, it's a simple one-liner.

I don't know why overflow: hidden is there, but you can just override it in your sortRowStyle with overflow: visible

Ah, good point, no need to modify the original base style.