ddollar / foreman

Manage Procfile-based applications

Home Page:http://ddollar.github.com/foreman

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Foreman does not terminate child process

baelter opened this issue · comments

Same issue as #628

Procfile:

worker: ruby test.rb

test.rb

pid = Process.spawn("sleep 100")
Process.detach(pid)
sleep

Steps to repoduce:

  1. $ foreman start
  2. $ kill <foreman-pid>
  3. Spawned process is still running

I think #723 addresses this issue. I rebased that branch against latest master, feel free to try it out: https://github.com/dentarg/foreman/tree/pgroup

I forked foreman and merged #780 (#723 but rebased) and released the fork as overman: https://github.com/spinels/overman, https://rubygems.org/gems/overman, #780 (comment)

@dentarg thanks for overman, I've replaced foreman with it in our dev setup.