ddollar / foreman

Manage Procfile-based applications

Home Page:http://ddollar.github.com/foreman

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Export for systemd ignores log flag

ClikeX opened this issue · comments

StandardOutput=syslog

Systemd template ignores the log location provided with foreman export. Which makes me unable to set a custom location for the process. And in turn makes the flag seem useless.

Seems like an oversight to me, or is there a particular reason why it isn't included?

@ddollar Are you willing to merge a PR when I add some options to configure SystemD parameters? Are there any wishes how these options should be named?

I think something like a --systemd prefix would be nice, like

foreman export systemd --systemd-StandardOutput=/var/log/mylog.log --systemd-StandardInput=/etc/myinput 

I'm not sure how to add these parameters to the Procfile though.. Maybe something like following?

webserver1: bundle exec rake sync_task SYSTEMD_StandardInput=... SYSTEMD_StandardOutput=...

I've created a PR for this, by adding log and error_log options - feel free to give feedback or merge :)

@ClikeX is this still an issue?

Of-course, still an issue.

@andrewmcodes In the end our team ended up not using the systemd logs as much as initially intended. So yeah, I guess this is still an issue if you really want systemd to handle your logs.

It seems like @h0jeZvgoxFepBQ2C was nearly finished with #717.