ddclient / ddclient

Ddclient updates dynamic DNS entries for accounts on a wide range of dynamic DNS services.

Home Page:https://ddclient.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Using password_env causes check_value to be called with $type uninitialized on each IP check

nallick opened this issue · comments

I'm using ddclient in Docker with the Cloudflare protocol. When I include my password directly in the configuration file it works file. When I switch to using a Docker secret and change to password_env in my configuration file it continues to work (so the configuration seems fine) but my log has 17 lines similar to the following for each IP check (i.e., every five minutes)

Use of uninitialized value $type in string eq at /usr/bin/ddclient line 2383.

I'm not a Perl expert, but it seems the check_value subroutine is being called without initializing the $type variable in this case.

I'm using the current Docker image lscr.io/linuxserver/ddclient:latest
Build: Linuxserver.io version:- v3.11.2-ls151 Build-date:- 2024-03-05T06:51:14+00:00

My configuration is:

daemon=300
syslog=yes
pid=/var/run/ddclient/ddclient.pid
ssl=yes
use=web, web=https://cloudflare.com/cdn-cgi/trace, web-skip='ip='
protocol=cloudflare,        \
zone=redacted.com,        \
ttl=1
password_env=API_TOKEN
redacted.com,another.redacted.com

Fixed in 981dd5f