ddakebono / PalworldRcon

Simple WPF/.net 7 Rcon tool for Palworld Dedicated Servers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Windows Registry

Peep opened this issue · comments

_rconSubkey = Registry.CurrentUser.OpenSubKey(@"Software\BTK-Development\PalworldRcon", true) ?? Registry.CurrentUser.CreateSubKey(@"Software\BTK-Development\PalworldRcon");

I don't think we should write/use the Windows registry for this kind of program -- and this does fail on some systems. Maybe writing into %userprofile%/AppData would be superior?

I can follow up with a pull request if I get some time, just wanted to mention this.

yeah, writting to the registry, especially writing a clear text password seems like a really bad idea