Giters

dbt-labs / dbt-common

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Audit dbt-common/dbt-core cross dependencies

colin-rogers-dbt opened this issue · comments

commented

Description

We need to review dependencies between dbt-core and dbt-common and clean them up. Let's:

  • Settle on what versions of shared dependencies we use
  • Remove duplicate specification of dependencies from common/core
  • Update developer docs in dbt-common and dbt-core
    • non v1 deps (ie. colorama) have documentation around why they're non-v1 and we use them and how they're pinned
    • link back to dbt-common docs where appropriate to avoid doc duplication

Acceptance Criteria

  • duplicate dependencies are consolidated between dbt-core and dbt-common
  • Final audit of dependencies is complete and we have finished consolidation/removal of duplicate or unnecessary dependencies.

Impact to Other Teams

None

Context

@MichelleArk and @emmyoop have already done some work on this ticket and should be consulted as needed.

commented

@colin-rogers-dbt Is this for dbt-common or dbt-adapters?

commented

@graciegoheen this is for dbt-common

commented

@MichelleArk @emmyoop Given that we don't want to merge dbt-labs/dbt-core#9725, what other work is required to mark this issue as done?

From my perspective, it looks like the A/C is already satisfied.

commented

@aranke - Would it be worth documenting the explicitly shared dependencies (in dbt-core setup.py, similar to this) so we don't accidentally remove/bump them independently going forward?