Promises not removing the document in migration
wzrdtales opened this issue · comments
Tobias Gurtzick commented
I'm submitting a...
- Bug report
- Feature request
- Question
Current behaviour
exports.down = function(db) {
return db.dropTable("pets");
};
// Returns:
[INFO] Defaulting to running 1 down migration.
collection migrations
collection pets
The code above remove the collection pets
but doesn't remove the document in the migration collection.
exports.down = function(db, callback) {
db.dropTable("pets1", callback);
};
// Returns:
[INFO] Defaulting to running 1 down migration.
collection migrations
collection pets1
[INFO] Processed migration 20190704145216-yop2
[INFO] Done
The code above works as expected, it removes the collection pets1
and remove the right document in the migration collection.
Expected behaviour
It should remove the right document in the migration collection when it succeed.
Environment
db-migrate@0.11.6
db-migrate-mongodb@1.5.0
Node version: v12.4.0
Platform: Mac
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Tobias Gurtzick commented
reported from db-migrate/node-db-migrate#632
/cc @gmahe