artifact location issue
brettowe opened this issue · comments
I'm seeing an issue that the scanner is saying the ocean hued clam set that I have on kokomi is on yoimiya.
not sure if others are doing this as this is the only load out that is it happening consistently and doesn't change
so its easy to notice that its missing when i import the latest scan into genshin optimizer
I have the same problem here, here is what the logs says :
[ INFO] 2021-12-10 09:03:39,400 / utils[236] /Corrected character from [Equipped: Ganyonomiya] to [Yoimiya] with distance 6
My version is the english one (2.5), I use the english client as well. It is probably a name parsing issue only present in the english version.
Can confirm I'm getting the same issue on my end
However, unlike @Shifumi95, Amenoma correctly identified Sangonomiya
on my end, but it doesn't seem to recognize who that is and auto-corrected to Yoimiya
...
[ INFO] 2022-04-09 19:53:49,479 /art_scanner_logic[102] /waitSwitched: 1 times, avg response time: 0.017634
[ INFO] 2022-04-09 19:53:57,304 / utils[236] /Corrected character from [Equipped: Sangonomiya] to [Yoimiya] with distance 6
[ INFO] 2022-04-09 19:53:57,304 / UIMain_EN[367] /Info message shown. msg=Detected [Sea-Dyed Blossom]
[ INFO] 2022-04-09 19:53:57,314 / UIMain_EN[908] /[ArtifactDB] Saved a Artifact. id: 1 detected info: {'equipped': 'Yoimiya', 'level': '+20', 'main_attr_name': 'HP', 'main_attr_value': '4,780', 'name': 'Sea-Dyed Blossom', 'subattr_1': 'ATK+4.1%', 'subattr_2': 'Energy Recharge+26.6%', 'subattr_3': 'HP+8.7%', 'subattr_4': 'DEF+16', 'type': 'Flower of Life', 'star': 5, 'locked': True, 'setid': 36}
[ INFO] 2022-04-09 19:53:57,314 / UIMain_EN[367] /Info message shown. msg=Saved
[ INFO] 2022-04-09 19:53:57,340 /art_scanner_logic[102] /waitSwitched: 1 times, avg response time: 0.022111
[ INFO] 2022-04-09 19:53:57,668 / utils[236] /Corrected character from [Equipped: Sangonomiya] to [Yoimiya] with distance 6
[ INFO] 2022-04-09 19:53:57,669 / UIMain_EN[367] /Info message shown. msg=Detected [Deep Palace's Plume]
[ INFO] 2022-04-09 19:53:57,680 / UIMain_EN[908] /[ArtifactDB] Saved a Artifact. id: 2 detected info: {'equipped': 'Yoimiya', 'level': '+20', 'main_attr_name': 'ATK', 'main_attr_value': '311', 'name': "Deep Palace's Plume", 'subattr_1': 'DEF+42', 'subattr_2': 'Energy Recharge+24.0%', 'subattr_3': 'HP+5.3%', 'subattr_4': 'ATK+4.7%', 'type': 'Plume of Death', 'star': 5, 'locked': True, 'setid': 36}
[ INFO] 2022-04-09 19:53:57,680 / UIMain_EN[367] /Info message shown. msg=Saved
...
From what I can see on the UI, her name doesn't get cut off or anything, so theoretically it should have been able to capture and OCR the entire thing
According to:
Amenoma/ArtScanner/rcc/char_map_v26.json
Line 36 in e352854
Amenoma will indeed only recognize her if it captures her full name
At least me not having Yoimiya (sadge) means I can just find+replace the result file, but yeah
This trouble is recorded as follows when checking Amenoma.log
[ INFO] 2022-06-09 18:29:15,040 / utils[236] /Corrected character from [Equipped: Sangonomiya] to [Yoimiya] with distance 6
[ INFO] 2022-06-09 17:04:54,528 / utils[236] /Corrected character from [Equipped: Kaedehara Kak] to [Kaedehara Kazuha] with distance 4
[ INFO] 2022-06-09 17:04:55,846 / utils[236] /Corrected character from [Equipped: Raiden Shogu] to [Raiden Shogun] with distance 1
[ INFO] 2022-06-09 17:04:57,956 / utils[236] /Corrected character from [Equipped: Kamisato Aya] to [Kamisato Ayaka] with distance 2
Correcting line 35 of ocr_EN.py as follows solved the problem.
original equipped_coords = [105, 1060, 500, 1100]
Revised equipped_coords = [105, 1060, 650, 1100]