onTapStart and onTapEnd

[Travis Arnold]

I know you want to keep the lib small. Wondering if we can add some extra callbacks though? I'm creating a Material design ripple and need an onStart and onEnd callback. And instead of handling it with two callbacks myself, it would be cool to utilize this lib for it since I need to listen for a tap anyways. So I was thinking the API could change to something like this:

var tapListener = createTapListener(element)

tapListener.onTapStart(function () {
})

tapListener.onTap(function () {
})

tapListener.onTapEnd(function () {
})

If this would be of interest to you I can try a PR. Just let me know :)

[Travis Arnold]

@davidtheclark any thoughts on this?

[David Clark]

On vacation right now, will get to this after I return.

On Sep 9, 2016, at 12:36 PM, Travis Arnold [e-mail] wrote:

@davidtheclark any thoughts on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[David Clark]

@souporserious That seems to me like a great idea! Open to a PR.

[Travis Arnold]

Awesome :) I'm busy right now, but when I get a chance I'll put together a PR.