davidtheclark / react-aria-menubutton

A fully accessible, easily themeable, React-powered menu button

Home Page:https://davidtheclark.github.io/react-aria-menubutton/demo

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Errors in <StrictMode />

nhardy opened this issue · comments

The component lifecycle componentWillMount will be deprecated in a future 16.x version of React and removed in React 17. This blog post explains more.

The legacy context API will also be removed in React 17, replaced with the new context API introduced in 16.3.

findDOMNode is also deprecated. This blog post explains more.

These three APIs currently log errors when rendered in a <StrictMode /> tree, and are a blocker for React's Concurrent Mode.

Use of deprecated lifecycle methods have been removed in v6.2.0

@nhardy Would like to send PR for findDOMNode and lgeacy context API ?

Happy to take a look if I get some time.

Sure let me know.

Going to also take a look at #93 which should remove the dependency on ReactDOM.findDOMNode() and close out the remaining issue not already addressed in #110. Unfortunately, React.forwardRef() is a backwards-incompatible API and would mean we would need to bump the peerDependencies for react/react-dom to 16.3.0.