MDC Context Null Pointer

Question

MDC Context Null Pointer

charliem opened this issue 5 years ago · comments

Whenever a new Server session is initiated by an inbound email a Null Pointer Exception is thrown. What appears to be happening is the parentLoggingMdcContext is null. The app this is being integrated into uses Log4J via SL4J. However it doesn't use MDC. I don't see why the context is coming back null but it is. Below is the exception produced:

Exception in thread "pool-4-thread-1" java.lang.NullPointerException
at org.slf4j.impl.Log4jMDCAdapter.setContextMap(Log4jMDCAdapter.java:81)
at org.slf4j.MDC.setContextMap(MDC.java:246)
at org.subethamail.smtp.server.Session.run(Session.java:126)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:835)

I solved this locally by guarding the setContextMap call with a Null check on parentLoggingMdcContext.

Dave Moten · Answer 1 · Fri Sep 06 2019 17:44:38 GMT+0800 (China Standard Time)

I haven't looked at the code yet but what versions of slf4j dependencies are you using?

Dave Moten · Answer 2 · Fri Sep 06 2019 17:59:20 GMT+0800 (China Standard Time)

Looks like this bug report on slf4j

Dave Moten · Answer 3 · Wed Sep 11 2019 05:33:22 GMT+0800 (China Standard Time)

I've added this null check as you described and released in 5.1 on Maven Central.