Possibly Remove Dependency to JSR305

Question

Possibly Remove Dependency to JSR305

in-fke opened this issue 10 months ago · comments

I would be great if we could remove the dependency to this "dormant" (rather dead) JSR305.
Actually, we currently have trouble with two Artifacts both exposing the package "javax.annotation" and JSR305 is one of them.

$ grep javax.annotation $(find . -name "*.java")
./src/main/java/org/subethamail/smtp/internal/server/ServerThread.java:import javax.annotation.concurrent.GuardedBy;
./src/main/java/org/subethamail/smtp/server/SMTPServer.java:import javax.annotation.concurrent.GuardedBy;
./src/main/java/org/subethamail/smtp/server/TimeBasedSessionIdFactory.java:import javax.annotation.concurrent.GuardedBy;
./src/main/java/org/subethamail/smtp/server/TimeBasedSessionIdFactory.java:import javax.annotation.concurrent.ThreadSafe;

Reference: https://stackoverflow.com/a/67415527/1747140

in-fke · Answer 1 · Thu Oct 05 2023 21:00:26 GMT+0800 (China Standard Time)

I forked the repo and did the changes there, in case you want to "copy" that.
in-fke#1

Dave Moten · Answer 2 · Sat Oct 07 2023 17:19:18 GMT+0800 (China Standard Time)

What is the other artifact? Can you just exclude the transitive dependency from subethasmtp in your pom (maven/gradle)?

Dave Moten · Answer 3 · Sat Oct 07 2023 17:21:58 GMT+0800 (China Standard Time)

I'm happy to exclude the artifact. Can you make a PR? Please leave comments where you remove the annotations (like // ThreadSafe, // GuardedBy this). Do not remove the parent pom block, that is used for deployment to Maven Central.