Giters

davidmoten / aws-maven-plugin

Deploys resources to AWS using maven

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Create AbstractAwsMojo

RoKish opened this issue · comments

commented

All MOJOs have a common structure, i. e. they all define the same parameters to configure proxy and AWS authentication, they all create Proxy and AwsKeyPair objects etc.

I think it's a good idea to create AbstractAwsMojo with an abstract method #execute(AwsKeyPair, Proxy, String) which all the other MOJOs will have to override. The execute() method of AbstractAwsMojo will be handling Proxy and AwsKeyPair objects creation and then calling #execute(AwsKeyPair, Proxy, String). This will allow to get rid of a lot of repetitions and add descriptions for all these common parameters.

Does it make sense?

commented

Yes it sure does make sense. A bit of technical debt begging to be sorted. Would you like to make a PR?