davidmarble / virtualenvwrapper-win

Port of Doug Hellmann's virtualenvwrapper to Windows batch scripts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

folder_delete.bat seems superfluous (and wrong'ish).

thebjorn opened this issue · comments

commented

folder_delete.bat (https://github.com/davidmarble/virtualenvwrapper-win/blob/master/scripts/folder_delete.bat) is only used by rmvirtualenv.bat, and boils down to this line:

for /d /r "%CD%" %%d in (%1) do @if exist "%%d" rd /s/q "%%d"

i.e. recursively iterate from %CD%, matching only directories into %%d, and then delete the directory (including subdirectories, quietly/without prompting). The if exist is there since the for-loop will delete parent directories before recursing into (now non-existent) sub-directories.

rmvirtualenv then tries to delete the directory tree, again, by itself calling rmdir /s /q:

call folder_delete.bat *
cd ..
rmdir "%1" /s /q

(https://github.com/davidmarble/virtualenvwrapper-win/blob/master/scripts/rmvirtualenv.bat#L42)

Changing it to read

cd /d "%WORKON_HOME%"
rmdir "%1" /s /q

seems to work well.