Prop changes in iframe-resizer-react are not respected
pm0u opened this issue · comments
Paul Mourer commented
If any of the event listeners are updated, these are not updated & re-bound to the iframe allowing stale event listeners to be run and preventing new event listeners from being added.
https://github.com/davidjbradshaw/iframe-resizer-react/blob/master/src/index.jsx#L25-L31
This dependency array should include all props for the react iframe resizer
Paul Mourer commented
Because our embedded iframe page has a ton of layout shift, I wish to ignore resize events for a time - but because this involves re-binding event listeners this is now impossible.