davidgohel / ggiraph

make 'ggplot' graphics interactive

Home Page:https://davidgohel.github.io/ggiraph

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

girafe_options() doesn't work with development version of htmlwidgets

cpsievert opened this issue · comments

Discovered via reverse dependency checks of htmlwidgets 1.6, which adds a new fill parameter to htmlwidgets::sizingPolicy()

Running ‘tinytest.R’
ERROR
Running the tests in ‘tests/tinytest.R’ failed.
Last 13 lines of output:
  diff| Component "defaultHeight": target is numeric, current is NULL
info| merge_sizing_policy works
----- FAILED[data]: test-girafe_options.R<268--281>
  call| expect_identical(result$sizingPolicy, policy, info = "sizingPolicy set")
diff| Component "defaultWidth": Modes: numeric, NULL
diff| Component "defaultWidth": Lengths: 1, 0
diff| Component "defaultWidth": target is numeric, current is NULL
diff| Component "defaultHeight": Modes: numeric, NULL
diff| Component "defaultHeight": Lengths: 1, 0
diff| Component "defaultHeight": target is numeric, current is NULL
info| sizingPolicy set
Error: 3 out of 1296 tests failed
In addition: Warning message:
  package 'ggplot2' was built under R version 4.1.2 
Execution halted

@cpsievert It's OK now - on cran