Public methods & structs

Question

Public methods & structs

deepu105 opened this issue 3 years ago · comments

Deepu K Sasidharan commented 3 years ago

Any plans to make the main methods and structs into public API so that this lib can be used as a library. I was trying to do something similar for https://github.com/kdash-rs/kdash and found this. I was hoping to use some of the functions from this instead of recoding it

David Bernard · Answer 1 · Sat May 22 2021 01:52:19 GMT+0800 (China Standard Time)

Sorry I didn't see the notification of the message. Yes I can definitly make stuff public

Deepu K Sasidharan · Answer 2 · Sat May 22 2021 23:05:22 GMT+0800 (China Standard Time)

That would be super cool

David Bernard · Answer 3 · Mon May 24 2021 01:48:43 GMT+0800 (China Standard Time)

I release 0.14 version. being used as lib is far to be top (no doc,...), so feel free to request any improvement.
https://docs.rs/kubectl-view-allocations/0.14.0/kubectl_view_allocations/

Deepu K Sasidharan · Answer 4 · Mon May 24 2021 02:37:25 GMT+0800 (China Standard Time)

Nice. I'll try to migrate to this in KDash and see if it needs any change. Will you be OK if I submit changes as PR?

David Bernard · Answer 5 · Mon May 24 2021 03:10:11 GMT+0800 (China Standard Time)

Yes PR are welcomed.
Anyway you made an impressive work with KDash 👏

Deepu K Sasidharan · Answer 6 · Mon May 24 2021 16:30:09 GMT+0800 (China Standard Time)

Thanks and right back at you :) Thanks & Regards, Deepu

…

On Sun, May 23, 2021 at 9:10 PM David Bernard ***@***.***> wrote: Closed #128 <#128>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIOKF2X5Q2FUEXFEV7EOV3TPFHKBANCNFSM43I34GWQ> .