Recognize .sc file extension as C code

Question

Recognize .sc file extension as C code

pbderr opened this issue 4 years ago · comments

My project has lots of C code with embedded SQL that is processed by the Oracle Pro*C pre-compiler. We use the ".sc" filename extension for these files. Could you please add ".sc" to your c_extensions list? Or, could you add an option to modify recognized filename extensions?

Thanks...

David A. Wheeler commented 3 years ago

Added!

David A. Wheeler · Answer 1 · Tue Feb 23 2021 23:29:25 GMT+0800 (China Standard Time)

We could easily add ".sc" as an extension. However, that wouldn't change how the code is parsed. Is the pre-parsed code "close enough" to C syntax that this would actually work?

pbderr · Answer 2 · Wed Feb 24 2021 00:25:44 GMT+0800 (China Standard Time)

David, Oracle SQL-embedded C code is almost exactly the same as Postgres embedded-SQL C which it seems you are handling. I think I see the list of file extensions in your c_extensions list, which includes two varieties of SQL-embedded C. I haven’t used Informix embedded C, but I have used both the Postgres and Oracle styles, and they are almost identical. The embedded SQL sections start with “EXEC SQL” (not case sensitive) and end with semi-colon (;). For example: { int a; /* ... */ EXEC SQL SELECT salary INTO :a FROM Employee WHERE SSN=876543210; /* ... */ printf("The salary is %d\n", a); /* ... */ } I’m hoping that simply adding this to your c_extensions would be sufficient: ‘.sc': 1, # Oracle SQL-embedded C. I believe ‘.pc’ is also commonly used, so you might also want this entry: '.pc': 1, # Oracle SQL-embedded C I see you also already have this entry: '.pcc': 1, # Oracle C++ It would be nice to have an option to allow configuring this list at run time. This is the current list I see: c_extensions = { '.c': 1, '.h': 1, '.ec': 1, '.ecp': 1, # Informix embedded C. '.pgc': 1, # Postgres embedded C. '.C': 1, '.cpp': 1, '.CPP': 1, '.cxx': 1, '.cc': 1, # C++ '.CC': 1, '.c++': 1, # C++. '.pcc': 1, # Oracle C++ '.hpp': 1, '.H': 1, # .h - usually C++. } Thanks, Peter

…

On Feb 23, 2021, at 10:29 AM, David A. Wheeler ***@***.***> wrote: We could easily add ".sc" as an extension. However, that wouldn't change how the code is parsed. Is the pre-parsed code "close enough" to C syntax that this would actually work? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AS6XPRWK57MOYNGJ6L45J3LTAPCWNANCNFSM4YCUR3AQ>.

David A. Wheeler · Answer 3 · Wed Feb 24 2021 00:39:56 GMT+0800 (China Standard Time)

I think at the least we should add the extension. One problem is that SQL is obviously not the same syntactically as C (!); is there an easy way we can easily detect & skip SQL statements?

Maybe it doesn't matter; as long as the SQL ends in a semicolon, we can at least easily resync, and most of the times the SQL statements are unlikely to trigger a false positive.