Seal KeyPair type

Question

Seal KeyPair type

yoshuawuyts opened this issue 6 years ago · comments

Yosh commented 6 years ago

We're forwarding the KeyPair type from another crate. We should create a wrapper type for this.

We should also be able to have a half-opened state for these - e.g. read-write vs just read

Antoine Bluchet · Answer 1 · Mon Aug 27 2018 15:45:57 GMT+0800 (China Standard Time)

We should also be able to have a half-opened state for these - e.g. read-write vs just read

Could the PartialKeyPair I added in #18 be the answer?

Yosh · Answer 2 · Mon Aug 27 2018 19:24:34 GMT+0800 (China Standard Time)

@soyuka yeah, definitely! Ideally we could remove any dalek structs from our public interface, and replace it the partial keypair. Would you like to give that a shot?

Antoine Bluchet · Answer 3 · Mon Aug 27 2018 20:10:33 GMT+0800 (China Standard Time)

We're not forwarding Keypair anymore if I'm not mistaken. The only thing I see here are Feed and FeedBuilder having PublicKey and Option<SecretKey>. Those two should stay like this.

You can close this imo.