datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io

Home Page:https://datahub.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

cURL zip file not printing output

Branko-Dj opened this issue · comments

Describe the issue

zip file not printing output when running curl command. Instead it prints warnings

Warning: Binary output can mess up your terminal. Use "--output -" to tell 
Warning: curl to output it to your terminal anyway, or consider "--output 
Warning: <FILE>" to save to a file.

How to reproduce

Expected behavior

you could read the data in terminal (or any prefered shell)

@Branko-Dj thanks for the issue 😀
Of course we can't affect the curl program to force it to unpack and show what's inside "zip".

But we can change our instructions, e.g.:

  • not show curl command for zipped resources
  • curl .../1.zip > 1.zip to save the file
  • wget instead of curl to save the file

I think the first variant is the better one.

This is a lines you should edit:
https://github.com/datahq/frontend/blob/8a2d2f5e015a8e769a674eae167fe291ed750fff/views/_instructions.html#L124-L125

@AcckiyGerman I am for the second option where users save files locally instead of printing

WONTFIX. I'm not sure this is worth fixing for now.