data missmatch issue in the Dataset ISO 6346 Container Type Codes
marcel-gross opened this issue · comments
Describe the issue
There seems to be a missmatch issue with the Dataset ISO 6346 Container Type Codes maintained by core:
Here some examples the records in the dataset show with our findings:
code,description,length,height,group
22B0,Bulk,20,8.5,22B0 <-- TypeCode 22B0 should belong to Group 22BU
20B0,Dry Bulk,20,8,22B0 <-- TypeCode 20B0 seems not to exist according Source Overview and/or https://en.wikipedia.org/wiki/ISO_6346
22BU,Dry Bulk,20,8.5,22B0 <-- Code 22BU seems to be the group whileg group 22B0 seems to be the code
According the Overviews available Container Type Codes do not contain a Number at the last position, while Container Type Codes do contain a number at the last postion (postion 4)
42H1,Thermal Refrigerated/Heated,40,8.5,42R1 <-- TypeCode 42H1 should belong to Group 42HR. While group 42R1 is a TypeCode which should belong to the Group 42RT.
49P0,Platform,40,4,49P0 <-- TypeCode 49P0 should belong to Group 49PL
49PL,Platform,40,4,49P0 <-- TypeCode 49PL sees to be a group while the Group 49P0 should be a TypeCode.
How to reproduce
- just look at the data in the dataset and compare with the source overview provided at:
- https://www.containercontainer.com/ISO6346 or https://en.wikipedia.org/wiki/ISO_6346
Expected behavior
code,description,length,height,group
22G0,Bulk,20,8.5,22GP
22B0,Bulk,20,8.5,22BU
42H0,Bulk,40,8.5,42HR
42R1,Bulk,40,8.5,42RT
49P0,Bulk,40,4,9PL
Thanks for your assistance
best regards
Marcel Gross
@marcel-gross Thanks for reporting this. We will fix it ASAP
Sorry - some correction for the Expected behavior, which should actually be more like this:
Expected behavior
code,description,length,height,group
22G0,General Purpose Conainer,20,8.5,22GP
22B0,Bulk,20,8.5,22BU
42H0,Insulated Container,40,8.5,42HR
42R1,Reefer Container,40,8.5,42RT
49P0,Platform,40,4,9PL
@marcel-gross FIXED, please see this issue datasets/ISO-Container-Codes#4. And also, republished to DataHub https://datahub.io/core/iso-container-codes. Good catch! Thanks for reporting this!
FIXED:
- containers codes are now fixed due to wikipedia.
Dear All
Thanks a lot for that rapid correction - brillant!
best regards
Marcel Gross