datawhalechina / torch-rechub

A Lighting Pytorch Framework for Recommendation Models, Easy-to-use and Easy-to-extend.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mistake in preprocess_ali_ccp.py

wyhwhy opened this issue · comments

In Line 81, vocabulary[k][v] should be set to 1 at first to coordinate with Line 90 (which should be >=10, for example). In this case the TRUE threshold is 12 now.

commented

@wyhwhy Thanks for noticing this detail, we will fix this mistake. We appreciate all contributions to improve torch-rechub. Welcome to participate in this project.

@wyhwhy Thanks for noticing this detail, we will fix this mistake. We appreciate all contributions to improve torch-rechub. Welcome to participate in this project.

Thanks for rely