datavis-tech / es-tabify

A function that converts ElasticSearch results into a table data structure.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add tests

curran opened this issue · comments

Unfortunately, the original tests from the proprietary codebase contain sensitive information, so could not be Open Sourced along with the tabify implementation. This issue is about adding unit tests for tabify.

If anyone wants to add tests, even the most basic, this would be very much welcome!

cc @boriscosic @nickmaccarthy

Oh hey! There's tests in the Python port:

https://github.com/nickmaccarthy/python-tabify/blob/master/tests/results.py

Maybe those could be ported into this repo.

@curran - Yes, I'll port them over for us.

@nickmaccarthy Awesome. Thanks a ton!