Question on Adding New Games
gndowns opened this issue · comments
Thanks for the great lib btw!
If I'm interested in adding support for a new game, can I go ahead and make a fork and open a PR myself? Or would it be better to start a discussion here on implementation first?
The game I'm interested in is "Oh Hell!", a trick taking game. I don't think there have been any trick based games implemented yet so this would be a cool new area to explore.
@gndowns Thanks for the interest! We welcome any contributions to new games. Basically, as long as the game is wrapped following the base class in https://github.com/datamllab/rlcard/blob/master/rlcard/envs/env.py, it will interface with the rest of RLCard.
Our brief intro is in https://github.com/datamllab/rlcard/blob/master/docs/adding-new-environments.md We recommend implementing the game following our design with classes of Game, Round, Dealer, Judger, Player. But you don't have to follow this as long as the higher-level interface of the environment is consisten since each game is different and may require different designs.
Additionally, it would be great if some testing scripts can be included as well, which will help us better maintain the game :)