datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists

Home Page:https://datacarpentry.org/python-ecology-lesson

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Environment link is broken

patricia-ternes opened this issue · comments

The link to download the environment file in the Summary and Setup is not working.

The problem is in the line 196 of the file learners/setup.md that can be access via this permalink

I believe the problem can be solved using the file path, something like:

[environment.yml](episodes/files/environment.yml)

The complete link should be generated automatically when deploy the material.

@patricia-ternes Thanks for your report! Would you like to submit a pr to fix this issue?

Yes, can you confirm if the path is the way to solve? I can do this now!

The url that works is: https://datacarpentry.org/python-ecology-lesson/files/environment.yml
So I think we need: [environment.yml](/files/environment.yml), since episodes becomes the root of the pages.

Thanks, you can assign this issue to me. I will submit a PR in some minutes. Thanks!

@patricia-ternes Thank you for you help with this issue!

Hello @btovar and @patricia-ternes, thank you for helping out with this fix and I apologise about the sparsity of the documentation about relative links. I've updated the workbench documentation to be a bit more clear about them: https://carpentries.github.io/sandpaper-docs/episodes.html#internal-links

The url that works is: https://datacarpentry.org/python-ecology-lesson/files/environment.yml So I think we need: [environment.yml](/files/environment.yml), since episodes becomes the root of the pages.

This is almost right with respect to thinking about relative paths, but in terms of working with The Workbench, since this is referenced from the learners/setup.md page, you will want to point to the file in the project relative to the page: [environment.yml](../episodes/files/environment.yml).

Thanks @zkamvar, that makes sense. I wasn't sure if the "episodes" part could be refer to after it becomes the root.