Add jakarta classifier for rider-junit5 module
rmpestano opened this issue · comments
JUnit5 module still uses the default rider-core version (javax compatible), in order to use the Jakarta compatible version in JUnit5 module the user has to play with maven exclusions and explicitly add the rider-core with jakarta classifier dependency.
Provide Jakarta classifier for junit5 module so user can just declare rider-junit5:
<dependency>
<groupId>com.github.database-rider</groupId>
<artifactId>rider-junit5</artifactId>
<version>1.41.0</version>
<scope>test</scope>
<classifier>jakarta</classifier>
</dependency>
It seems that the rider-junit5 jakarta module is completely wrong:
- it still references the core module without the jakarta classifier.
- it still uses
javax.persistence
. For example in theEntityManagerProvider
.
Hey @jonasrutishauser, EntityManagerProvider was not migrated to Jakarta, I'll reopen this issue.
Besides that you face other issues?
At the moment, we explicitly reference the core with the jakarta qualifier and overwrite the EntityManagerProvider
class with a javax
to jakarta
replaced variant. Additionally, we need a Junit5RiderTestContext
compiled against the modified EntityManagerProvider
to avoid a NoSuchMethodErrror. That's all to make our test running.