It's not possible to use dbunit.yaml (instead of yml)

Question

tiagomistral opened this issue a year ago · comments

This is just a minor issue but it's not possible to use the file dbunit with .yaml extension since the code only looks for dbunit.yml .

This is not a problem with this library itself, but it would be an asset if the existence of the file with both extensions was verified.

As the helm chart checks for the existence of yaml files with this extension, I can't have a pattern in my project.

Thanks in advance

Rafael Pestano · Answer 1 · Thu Apr 06 2023 09:23:33 GMT+0800 (China Standard Time)

Hey @tiagomistral, would you or anyone like to contribute and fix that with a PR?

Thank you for the feedback.

tiagomistral · Answer 2 · Wed Apr 19 2023 00:47:22 GMT+0800 (China Standard Time)

Yes sure :D

Do I had permissions to create a PR? Can you point some guide how to do it?

Rafael Pestano · Answer 3 · Wed Apr 19 2023 22:20:05 GMT+0800 (China Standard Time)

Yes sure :D

Do I had permissions to create a PR? Can you point some guide how to do it?

Hey Tiago, yes you should be able to fork the project, push the changes to your branch and open a PR.

On top of my head this is the only place where we read that file.

If you make that change, just add a test here for the new suffix should be enough

Let me know if you need any help