Giters

data-for-change / anyway

ANYWAY - Car accidents map

Home Page:http://www.anyway.co.il

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

road segment infra - improvements

atalyaalon opened this issue · comments

commented

Ziv, awesome work with the road segments infra (that includes junctions of course)

Following both this pr and this one

I think we should:

  1. Make sure we stop using road_segment_name in API at all, only road_segment_id (Also in news flashes - make sure we add to the news flash the road_segment_id rather than road_segment_name like we do today).
  2. Verify we have both road_segment_id and road1 in each interurban query (perhaps this already exists?), and perhaps raise error if not.
  3. Create a unified infra for location filters (per resolution type). I think we're almost there.
    Is it possible, for example, that we're missing a certain widget that does not use "get_expression_for_road_segment_location_fields" in one of the queries and hence we don't use the junctions data?
    (@ziv17 I know you've made a very thorough work - adding it to get_query function for example - but wondering how can we make sure we don't forget it in the next widget we're creating (it can also be by having a documentation on how to construct a query and not by code)
    Of course we need to consider different queries that are a part of the code but do not filter the segment for some reason (for example, in head_on_collisions_comparison_widget.py we have a query of all roads in Israel - hence we don't filter the road segment there)
commented

Hi @atalyaalon ,
regarding No2 above, "Verify we have both road_segment_id and road1". Road segment identifies also the road. Why do we require to get also the road?

commented

Hi @atalyaalon
by "Make sure we stop using road_segment_name in API at all", you mean to fail requests that use it, or convert it to road_segment_id?

commented

Hi @atalyaalon , regarding No2 above, "Verify we have both road_segment_id and road1". Road segment identifies also the road. Why do we require to get also the road?

as discussed we don't need it to have both in the query. What we might need is to make sure road1 is in "location_info" and in "news_flash" object, since the road1 (and also road_segment_name) is used in titles for example

commented

Reference in new

as discussed, yes, we don't want to query by road_segment_name, only by id

commented

Hi @atalyaalon ,
I think the location accuracy PR (#2641) closes this issue.

commented

PR (#2641) closed this issue.