include without quoted filename misbehaving
andrew-davie opened this issue · comments
If you include a file without quotes surrounding the filename, dasm does actually include the file correctly...
but it also lists the filename as an unresolved symbol.
The manual, and here I'm being a bit self-referential, specifies that the include uses quotes around the name. Or more specifically it does not list the format without quotes.
My preference is to require quotes and flag non-quotes as an error... but this would probably break a lot of stuff.
The next best is to fix things up so that includes without quotes do not generate "unresolved symbol" warnings.
--- Unresolved Symbol List
NO_ILLEGAL_OPCODES 0000 ???? (R )
vcs.h 0000 ???? (R )
RowGfx.h 0000 ???? (R )
macro.h 0000 ???? (R )
Colors.h 0000 ???? (R )
--- 5 Unresolved Symbols
It's pretty clear what the includes were.
One argument for requiring quotes - let's say I had a weird filename like + (the symbol + without anything else). In this case
include +
Will fail with an error, whereas the quoted form will work just fine.
Another way of saying this, it seems that dasm is parsing the line without quotes as if the parameter was a symbol, and so it is thus required to obey symbol syntax/rules -- which is definitely not the case with filenames.
So, I believe this is an issue that needs addressing as a bug, not just lacking documentation.
If you include a file without quotes surrounding the filename, dasm does actually include the file correctly...
but it also lists the filename as an unresolved symbol.
This does not happen for me (Win10) anymore(?). Has this been fixed?