dart-lang / collection

The collection package for Dart contains a number of separate libraries with utility functions and classes that makes working with collections easier.

https://pub.dev/packages/collection

Consider changing UnionSetController constructor into a factory

jakemac53 opened this issue 4 years ago · comments

Jacob MacDonald commented 4 years ago

See context here https://github.com/dart-lang/collection/pull/123/files/67f1b6438c3d7045b82dc6a14f0b988ab81c9e2f#r393273134

This would allow the _set field to be non-late in nnbd.

Lasse R.H. Nielsen commented 4 years ago

It's technically a breaking change, but I'm open to trying it. It's an implementation class, nobody should be extending it.

I'm also not particularly fond of the class to begin with, it seems overly specialized.