Comments remove `WP_Scripts::localize ` error

[Joonas Meriläinen]

I was testing the new awesome application.discussion => false feature and noticed that it calls the Comments::remove() which calls BlockEditor::set('discussion', true) and finally it will call wp_localize_script('intervention-block-editor', 'config', 'discussion'). But the wp_localize_script function requires the last parameter to be array so it errors out.

Should the BlockEditor::set('discussion', true) be removed or have different value? (Or if it is still working progress, sorry to rush :D)

[Darren Jacoby]

Hey @jmerilainen ,

I wasn't able to re-create the error, but did make a change, would you mind testing on your side for me?

b58bd8

[Darren Jacoby]

@jmerilainen just checking in here, let me know.

[Joonas Meriläinen]

Hey @darrenjacoby,

Sorry for ghosting suddenly, other things got over the way.

Yeah the format is now alright! But I still caught a minor error on front end which is missing dependencies of intervention-block-editor script. It requires wp-blocks, wp-edit-post scripts but I think those are enqueued only on admin.

I'm not yet super familiar with the codebase but for example this did the trick:

if (is_admin()) {
    BlockEditor::set(['discussion']);
}

[Darren Jacoby]

@jmerilainen thanks, added into BlockEditor.php and will release soon!