Post types with "-"

Question

Post types with "-"

cb3rnard opened this issue 2 years ago · comments

Hello !
First of all, this plugin is fantastic and really usefull. I use it on many website.
Today I stumbled on a little issue, which prevents me from updating theme custom types : the slugs include the symbol '-', which is overwritten with '_' in Intervention. Example : "portfolio-item" or "show-item"
Could it be possible to check for both versions when looking for the existence of a custom type ?
Thanks in advance

Darren Jacoby · Answer 1 · Fri Jun 24 2022 02:28:52 GMT+0800 (China Standard Time)

Sure, I will take a look and see if I can check for both!

cb3rnard · Answer 2 · Fri Jun 24 2022 03:31:34 GMT+0800 (China Standard Time)

Thanks ! I added a few lines in Posttypes.php but it would be even better if it was included :-)

cb3rnard · Answer 3 · Fri Jun 24 2022 03:35:40 GMT+0800 (China Standard Time)

Just realized that same goes for taxonomies. Damn themes...

Darren Jacoby · Answer 4 · Wed Mar 22 2023 00:12:15 GMT+0800 (China Standard Time)

@cb3rnard I'm going to recommend moving registering post types and taxonomies away from Intervention. I want focus on removing things from WordPress versus registering, etc. It feels outside scope to keep the plugin lean.