Giters

daroczig / binancer

An R client to the Public Rest API for Binance.

Home Page:https://daroczig.github.io/binancer

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add timeout option

dimitry-ishenko opened this issue · comments

commented

With an unreliable connection calls to binance_klines() will sometimes hang and never return. The httr package supports timeout() option for the GET() function: https://rdrr.io/cran/httr/man/timeout.html

Ideally this option would be exposed in binancer or at least a sane default chosen (if there is one 😄 )

commented

Thanks, this is a good suggestion and pretty easy to implement -- I can get back to this in a couple weeks after the eRum 2018 conference

commented

Sorry for the long delay with this :/
Some updates just went out with better error handling -- can you please check if it's still an issue?

commented

Feel free to close. I've moved on