darklife / darkriscv

opensouce RISC-V cpu core implemented in Verilog from scratch in one night!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Useless commit messages

dolmen opened this issue · comments

Commit messages have all "Changes to be committed:" as the first line and then contain only a list of filename. This is is quite useless (well, unless to write a big project in one night).

See best practices: https://chris.beams.io/posts/git-commit/

Which bit of written in 1 night did you miss ;)

@ddimmich As far as I understand, everything that was the 1 night is in the first ~3 commits as the 4th commit adds the "somewhere between 2am and 8am" in which it was developed to the README and there are many commits after that.

After decades away from the open source community, my lack of ability with this new tool called "git" is very evident! Thank you for point the problem and thank you for the best practices link! :)