`attohttpc` is a thread-blocking HTTP client

Question

`attohttpc` is a thread-blocking HTTP client

thomaseizinger opened this issue a year ago · comments

As far as I understand, https://docs.rs/attohttpc is a blocking HTTP client and doesn't use async. Now that we have integration with two runtimes, we should probably use an async client or hyper directly.

See https://github.com/dariusc93/rust-igd/blob/master/src/gateway.rs#L28-L32.

João Oliveira · Answer 1 · Tue Sep 12 2023 00:50:58 GMT+0800 (China Standard Time)

can we feature gate the whole blocking mod? If you want to make it non (or less as someone might be misusing the default-features) breaking you can add it to the default-features

Thomas Eizinger · Answer 2 · Tue Sep 12 2023 07:09:34 GMT+0800 (China Standard Time)

Ah, I had no idea this code was duplicated with the non-blocking mode! Yeah feature-gating would be ideal to reduce our dependency tree :)

João Oliveira · Answer 3 · Tue Sep 12 2023 07:50:35 GMT+0800 (China Standard Time)

Ah, I had no idea this code was duplicated with the non-blocking mode! Yeah feature-gating would be ideal to reduce our dependency tree :)

yeah we are using aio::gateway :)

Thomas Eizinger · Answer 4 · Tue Sep 12 2023 08:00:03 GMT+0800 (China Standard Time)

Nice! I guess this issue can be seen as implementing the feature flag then :)