danro / LESS-sublime

LESS syntax highlighting for Sublime Text.

Home Page:https://sublime.wbond.net/packages/LESS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mixin falsely highlighted as "normal class"

katerlouis opened this issue · comments

image

as you can see .mixin; does not get the same syntax highlighting as .mixin2()

PS: Is there a way to change colors? normal classes are too close to properties in my opinion.

EDIT:
I find the old version (1.0.1) way more readable and consequent. A class can be a mixin at the same time, so I don't see a reason to distinguish between them. But that's just my opinion.
image

Well a mixin with the () is subtly different, but I get your point. It's not completely to my liking right now so I'll look at it.

What colors end up being used is outside my control though, that something for the color scheme. With recent dev builds of ST you get to override color schemes to tweak colors, but I'm not 100% how that works yet.

Interesting; both images are created with the same color scheme. So maybe you do have control over how the syntax highlighter labels the corresponding strings which then get colored by the color scheme? If I am correct I suggest sticking with the same labels as before whenever possible, so people don't have to adjust their color schemes too much :) –

Until this is solved I have to stick to 1.0.1 and hope ST doesn't update it :D

The LESS plugin labels parts of the code (somewhat like CSS classes), the color scheme takes those labels and assigns colors to them. Your color scheme seems to make meta.selector green-ish, and entity.other.attribute-name.class yellow-ish. Without knowing how the color scheme is defined it's impossible to say what labels it picks up on though.

What I did now was make the label for classnames and mixins mostly the same, so they should get the same colors. In your case I think that means they'll be green-ish, not the yellow-ish that they were in the old version. That probably has to do with the fact that we're now labelling stuff similarly to what the CSS package does and according to guidelines, whereas the old version just did whatever.