danobi / prr

Mailing list style code reviews for github

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Comments on large diffs are not accepted

drahnr opened this issue · comments

> diff --git a/foo.json b/foo.json
> deleted file mode 100644
> index f132fcb..0000000
> --- a/foo.json
> +++ /dev/null
> @@ -1,150 +0,0 @@

Please don't delete this mingled with other changes in the same PR

> -{
> -  "name": "baz",
> -  "id": "bar",
> -  "properties": null,
// many more lines
Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread path diff too large and Pull request review thread diff hunk can't be blank"],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}

When I try leaving a comment on the 0 line I get this error:

Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread line required and an integer greater than zero and Pull request review thread diff hunk can't be blank"],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}

which is different than your error.

Maybe GH has limitations on which files can be commented on? eg for too large of diffs? Not sure